src: lazily initialize global BuiltinLoader#46256
Closed
addaleax wants to merge 1 commit intonodejs:mainfrom
Closed
src: lazily initialize global BuiltinLoader#46256addaleax wants to merge 1 commit intonodejs:mainfrom
addaleax wants to merge 1 commit intonodejs:mainfrom
Conversation
Using simdutf during startup can fail when compilation units are linked in the wrong order by a static initialization order issue. nodejs#46235 would also solve this, but since that is a larger effort, this patch focuses on solving the immediate problem. Alternatively, simdutf should arguably be made usable during static initialization, but that is also not as straightforward as this patch. Fixes: nodejs#46235
Collaborator
|
Review requested:
|
Member
|
Working on a patch in simdutf. I flagged the issue in simdutf back in 2021... simdutf/simdutf#87 but it was theoretical at the time and I never revisited it. |
Collaborator
Member
|
@addaleax If you prefer, I have the following patch in simdutf: simdutf/simdutf#209 It should solve the issue. |
Member
|
Upgrading to simdutf 3.1.0 is an alternative fix. |
Member
Author
Member
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using simdutf during startup can fail when compilation units are linked in the wrong order by a static initialization order issue.
#45942 would also solve this, but since that is a larger effort, this patch focuses on solving the immediate problem. Alternatively, simdutf should arguably be made usable during static initialization, but that is also not as straightforward as this patch.
Fixes: #46235